Add missing variable to light theme #43117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
|
should it not be the same as elsewhere eg com_categories |
|
Yes it should. I dont know why people decide to use different classes for same things all over the backend. That makes things really hard. :-) |
|
I would fix the markup to use the correct class rather than the css |
|
Ok then I need a decision if this should be a btn-secondary or in all other views a btn-info |
|
I did an additional PR for the markup #43120 |
wilsonge
approved these changes
Mar 22, 2024
|
I have tested this item ✅ successfully on 2d367a0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43117. |
1 similar comment
|
I have tested this item ✅ successfully on 2d367a0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43117. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43117. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Add missing variable in light mode
Actual result BEFORE applying this Pull Request
Before this PR
Expected result AFTER applying this Pull Request